I agree those parts (Lemfoerder) look good. It might be that some don't actually need replacement yet, but since you're paying someone else to do it, it makes sense to just get them all replaced now. Lemfoerder was the OES on most (all?) of those parts, so they should be as good as the BMW branded ones. Unlikely that you'll need the FCP warranty, but nice to have.

BTW, one challenge with these suspensions is that due to how they are spring loaded, the whole thing is under stress, keeping things tight and making it difficult to diagnose looseness before things are apart. It is somewhat possible to de-stress the spring by jacking it at the spring perch, with a special jack, but still, you will learn much more about how worn things are only when they are fully disassembled. For me, I did it all myself, with no rush, so could take it apart and figure out what I needed once I got in there, order the parts, etc.

Considering your tire wear and mileage, your plan sounds great to me.

__________________
2001 X5 3.0i, 203k miles, AT, owned since 2014