Pete, it really depends on what YOU like. Do you like the new E90? I'm not a big fan of the new Bangle designs. The interior does not jump out and grab me like the older interiors have. The exterior is OK -- the best of the Bangle designs. I think the E46 is a sharp looking car but what do I know
I say if you like the E90 go for it. Its just at the beginning of its life cycle and won't be replaced for another 6 years. You might have to deal with some nagging problems being a first year production, but hopefully they will be small enough that they won't be a big deal.