wheel noise - tires or wheel bearings or something else?
 

most noise at about 40mph less at highway speed
vibration noise, "pump" "pump" "pump" "pump" from front of car more noticeable with window closed then opened. No vibration in searing wheel, Not much difference when turing.

BACKROUND:
replaced front bearings at 122K, 167K at present - that makes only 45k on new bearing - BUT - I did them myself with Harbor Freight tools, (unfortunately I always doubt/suspect my work first).
New tires 1 year ago, 150K
New shocks/struts 150K
New brakes/rotors 160k

(dumb part) - I never got the car aligned after new tires and shocks

(confusing part) - I rotated the tires, back to front (yes, I know we are not supposed to rotate X5 tires) and I thought the noise was stronger. Noticed only one tire had 1 "glue on" balance weight on inside and I can't remember if they were all removed when I got the new tires when they added the hammer on weights on the inside of the rims.

I want to think I "cupped" my tires because my alignment is off, I was hoping when I put the rear tires on the front it would go away not get more noticeable. I fear its a bearing, but tire change shouldn't make a difference and Its not a steady "growl" like when my rear bearing failed (under warranty).

I'd be checking tyre pressures and getting them all balanced first.

If it's less noise at highway speeds it's no way it's your bearings. Those are louder at 40 mph and up

Thanks for the input.
I was hoping I was over-reacting
Even though tire issue might be the more $ fix, the bearings were a job I did not want to repeat.

Depending on the tyre wear patterns, modifying the pressures can make quite a big difference to the noise generated. Perhaps try increasing them by 4PSI all-round - see what transpires. But a balance is definitely on the cards.

Fronts were terrible. I did both mine last year at 70k miles. Yes I know, its ridiculous that a bearing went at that low of mileage. PO must have cracked a pothole pretty bad because the RF bearing was shot and howling like a WWII bomber over 40mph. I did both sides for good measure, all quiet since then.

But you're right, not something I'd like to repeat again before 200k.

When you reinstalled the new hub nut (s) did you torque to 330 lb pounds?

Yes - another Harbor Fright "one time tool" (torque wrench higher that 200)

For safety - jacked up each wheel and checked for any "shake", all seems tight

Yes, but I did it the old fashioned way, by placing a certain amount of weight at a certain length of pipe. I placed my breaker bar (20") on the nut and slipped the jack handle extension over it more (making it a "cheater bar"), and since I am approx 185 lbs, I stood at the 21" mark to torque the bolt to 330 ft lbs.

Its the old school and garage mechanic way to do it but it worked quite awesome I must say.

I looked at the HF 300 ft lb torque wrench but didn't want to spend 80 bucks for a tool I will literally use once. I had enough "one time use" tools from that job lol

I saw my tire guy today, he said defiantly mechanical noise, not tire. His guess is bearing. My replacement bearing I used were FAG, as understood by Bavarian Autosport as "original BMW" but I see FCP is selling what they list as "BMW" bearings for twice as much as there FAG. Curious as to what brand others replaced with??

My gut has me thinking my noise was always/is bearing noise and I am trying to convince myself otherwise.
I will attempt it again, but will have them pressed in/out by machine shop. I never got a good feeling that the manual bolt/dies gave an even, clean install.
Tire guy didn't think it sounded too bad and not an immediate need, but I don't like it and will probably be laying out in the driveway in zero degree winter.

Loved Ricky Bobby's old school lesson. Wy too many "one time tools" involved in German cars